fix(web): fix KeyboardStub.validateForCustomKeyboard#16067
Open
ermshiperete wants to merge 1 commit into
Open
Conversation
This change fixes a misleading error message in `validateForCustomKeyboard` - `KR` is not the region as the error implies - furthermore it doesn't make sense to check `KR` since it is the optional [keyboard registration function](https://help.keyman.com/developer/engine/web/18.0/reference/interface/registerKeyboard), so this change removes it. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Jun 8, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
LGTM although I hate the way this returns an Error rather than just a boolean. The error message itself undoes the good of having a super function because it includes knowledge of what the super function tests! Error message construction does not belong in the validation function IMO, but in the higher level.
What's more, this is called in just one place in keyboardRequisitioner.ts, but we have two functions, one with an Error message that is never used, just constructed and then thrown away in the subclass. We could (and should) simplify so many of these abstractions and reduce the complexity of KMW.
Weird: keyboardLoaderBase.ts has:
export type KeyboardStub = KeyboardProperties & { filename: string };but KeyboardStub is defined in keyboardStub.ts:
export class KeyboardStub extends KeyboardPropertiesAnd we have RawKeyboardStub vs KeyboardStub:
export interface RawKeyboardStub extends KeyboardStub {};I don't understand why all these are necessary!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a misleading error message in
validateForCustomKeyboard-KRis not the region as the error implies - furthermore it doesn't make sense to checkKRsince it is the optional keyboard registration function, so this change removes it.Test-bot: skip